Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent scrolling toolbar with content #1305

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Prevent scrolling toolbar with content #1305

merged 1 commit into from
Feb 23, 2018

Conversation

arxeiss
Copy link
Contributor

@arxeiss arxeiss commented Feb 22, 2018

If content is wider than screen, during scrolling toolbar is not moving anymore.

image

If content is wider than screen, during scrolling toolbar is not moving anymore.
@mAAdhaTTah
Copy link
Member

I dig it, and I don't see any complications.

@mAAdhaTTah mAAdhaTTah merged commit 6d85a47 into PrismJS:gh-pages Feb 23, 2018
@mAAdhaTTah
Copy link
Member

@arxeiss Thank you for the contribution!

@Golmote
Copy link
Contributor

Golmote commented Feb 23, 2018

@mAAdhaTTah @arxeiss Shouldn't we check for the existence of the wrapper so that calling Prism highlighting multiple times on the same block does not add multiple toolbars? (Condition on line 62 suggests this case was handled before)

@arxeiss
Copy link
Contributor Author

arxeiss commented Feb 23, 2018

@Golmote You are right! I did not see it..
And I found maybe another problem. That if another plugin will need wrapper as well, there can be conflict. Maybe adding some wrapping method to the core? That only 1 wrapper can be present?
Any ideas?

@Golmote
Copy link
Contributor

Golmote commented Feb 23, 2018

I think it's OK if we don't handle this in a generic way for now, cause we don't need other wrappers.

@mAAdhaTTah
Copy link
Member

@Golmote Nice catch, and agreed. If we need a wrapper for other plugins, we can develop a generic method then.

@arxeiss arxeiss mentioned this pull request Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants