Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python builtin function highlighting #1205

Merged
merged 6 commits into from
Oct 21, 2017
Merged

Add Python builtin function highlighting #1205

merged 6 commits into from
Oct 21, 2017

Conversation

ecterceocgan
Copy link
Contributor

List of builtin functions comes from: https://docs.python.org/2.7/library/functions.html

@ecterceocgan ecterceocgan changed the base branch from gh-pages to master October 12, 2017 15:57
@ecterceocgan ecterceocgan changed the base branch from master to gh-pages October 12, 2017 16:07
@Golmote
Copy link
Contributor

Golmote commented Oct 19, 2017

Hi @erinwild! Thanks for contributing.
Would you mind adding/updating the tests for this (see http://prismjs.com/test-suite.html and existing tests: https://github.com/PrismJS/prism/tree/gh-pages/tests/languages/python).
Also, please run gulp on your local version to generate the minified version of the component.

@Golmote
Copy link
Contributor

Golmote commented Oct 19, 2017

While you're at it, could you also add the nonlocal keyword, requested in #1208 ?

@ecterceocgan
Copy link
Contributor Author

@Golmote Done!

@Golmote Golmote merged commit 2169c99 into PrismJS:gh-pages Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants