Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[File Highlight] support adding a link in some corner of the code block for downloading #1030

Closed
xuhdev opened this issue Oct 3, 2016 · 8 comments

Comments

@xuhdev
Copy link
Contributor

xuhdev commented Oct 3, 2016

It would be nice if File Highlight can insert an additional download link for readers to download the original file that prism.js displays.

@Golmote
Copy link
Contributor

Golmote commented Mar 26, 2018

I added a basic feature to do that. See http://prismjs.com/plugins/file-highlight/

@mAAdhaTTah
Copy link
Member

@Golmote I'm not seeing the download link on the linked page.

@Golmote
Copy link
Contributor

Golmote commented Apr 16, 2018

@mAAdhaTTah On the last example? I can see it working properly...

@mAAdhaTTah
Copy link
Member

Yeah, looks like this in the Chrome devtools:

banners_and_alerts_and_developer_tools_-_http___prismjs_com_plugins_file-highlight_

Toolbar doesn't have anything in it. :/

@Golmote
Copy link
Contributor

Golmote commented Apr 17, 2018

@mAAdhaTTah I've just fixed an issue in cd22499, but it seems totally unrelated to the issue you're showing there.
I don't get it, I can't reproduce the issue on neither Firefox nor Chrome. Are you sure you don't have some sort of browser cache or something?

@mAAdhaTTah
Copy link
Member

Weird... let me clone the repo locally and dig into it.

@Golmote
Copy link
Contributor

Golmote commented May 1, 2018

@mAAdhaTTah Did you find anything? 😟

@mAAdhaTTah
Copy link
Member

Haven't had a chance to dig into it–just moved into a new place. It's on my todo list tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants