PHP: Add support for multi-line strings. Fix #1233

PrismJS · Nov 28, 2017 · 9a542a0 · 9a542a0
1 parent de6de45
commit 9a542a0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/components/prism-php.js b/components/prism-php.js
@@ -12,6 +12,10 @@
  */
 
 Prism.languages.php = Prism.languages.extend('clike', {
+	'string': {
+		pattern: /(["'])(?:\\[\s\S]|(?!\1)[^\\])*\1/,
+		greedy: true
+	},
 	'keyword': /\b(?:and|or|xor|array|as|break|case|cfunction|class|const|continue|declare|default|die|do|else|elseif|enddeclare|endfor|endforeach|endif|endswitch|endwhile|extends|for|foreach|function|include|include_once|global|if|new|return|static|switch|use|require|require_once|var|while|abstract|interface|public|implements|private|protected|parent|throw|null|echo|print|trait|namespace|final|yield|goto|instanceof|finally|try|catch)\b/i,
 	'constant': /\b[A-Z0-9_]{2,}\b/,
 	'comment': {

diff --git a/components/prism-php.min.js b/components/prism-php.min.js
diff --git a/tests/languages/php/string_feature.test b/tests/languages/php/string_feature.test
@@ -1,11 +1,17 @@
 "https://example.com"
 " /* not a comment */ "
+"multi-line
+string"
+'multi-line
+string'
 
 ----------------------------------------------------
 
 [
 	["string", "\"https://example.com\""],
-	["string", "\" /* not a comment */ \""]
+	["string", "\" /* not a comment */ \""],
+	["string", "\"multi-line\r\nstring\""],
+	["string", "'multi-line\r\nstring'"]
 ]
 
 ----------------------------------------------------