Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More options for Bharm calculation #40

Open
zhucaoxiang opened this issue Nov 25, 2019 · 4 comments
Open

More options for Bharm calculation #40

zhucaoxiang opened this issue Nov 25, 2019 · 4 comments
Assignees

Comments

@zhucaoxiang
Copy link
Collaborator

@logan-nc @ysm1887

The new feature of bharm_jsurf is now in the develop branch and ready for test.

To use it, just specify the bharm_jsurf = 0 (or 1, 2) in the input namelist. Here are the detalis of each option
image

Additional normalizations are added to be aligned with GPEC results.

  • bharm_jsurf=0, GPEC = 2*FOCUS
  • bharm_jsurf =1, GPEC = 2*(4*pi^2)*FOCUS
  • bharm_jsurf=2, GPEC = 2*(2*pi)*FOCUS

Here is a simple test against GPEC using KSTAR RMP coils.
image
Zoomed in
image

Most of the modes are consistent. A discrepancy was observed in phasing angles for high m modes. One guess is that FOCUS is using a Fourier representation for coils, while GPEC might not (need confirmation).
image

@logan-nc
Copy link
Collaborator

Awesome! Thanks @zhucaoxiang!
@ysm1887 please let us know once you have put the necessary 2's and pi's into the OMFIT interface between GPEC and FOCUS. Once that is done, I'll close this issue.

@zhucaoxiang
Copy link
Collaborator Author

@logan-nc @ysm1887 I have put the additional normalizations (2’s, pi’s) into the FOCUS source code. The figure I showed above is the raw output from FOCUS.

@logan-nc
Copy link
Collaborator

Ok @zhucaoxiang, so we can use the GPEC "dominant mode" that has bharm_jsurf=2 as input to FOCUS without any additional normalization?

@logan-nc
Copy link
Collaborator

@zhucaoxiang the namelist I start from seems to contradict the documentation in this thread:

bharm_jsurf = 0 ! 0: no weightes; 1: weighted with area square; 2: weighted with area

Should we change all the namelists to read

! 0: no weightes;  1: weighted with area; 2: weighted with sqrt area

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants