Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultivariateStats + StatsAPI #210

Closed
wants to merge 7 commits into from
Closed

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Oct 15, 2023

Closes #203 (replaces #204)

NB this bumps the Julia version to 1.9, as the MV code is only loaded when MultivariateStats is loaded, using the new Weak Dependencies system -- the same thing will happen for Clustering

@github-actions
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (639a48d) 52.83% compared to head (7ae5b8f) 52.49%.
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #210      +/-   ##
==========================================
- Coverage   52.83%   52.49%   -0.34%     
==========================================
  Files          59       60       +1     
  Lines        1711     1722      +11     
==========================================
  Hits          904      904              
- Misses        807      818      +11     
Flag Coverage Δ
unittests 52.49% <0.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/SpeciesDistributionToolkit.jl 100.00% <ø> (ø)
src/integrations/makie.jl 0.00% <ø> (ø)
src/quality_of_life.jl 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpoisot tpoisot changed the base branch from main to next October 15, 2023 15:30
@tpoisot
Copy link
Member Author

tpoisot commented Oct 15, 2023

This currently supports fit, predict, and transform for PCA, kPCA, PPCA, MDS, Metric MDS, and Whitening, which should be a good enough basis to work from -- the code is slow but I'll optimize later

@tpoisot tpoisot marked this pull request as ready for review October 15, 2023 15:50
@tpoisot
Copy link
Member Author

tpoisot commented Oct 16, 2023

@gottacatchenall check this out, I think this doesn't suffer from the fit issue with StatsBase

@gottacatchenall
Copy link
Member

That's interesting, I haven't seen StatsAPI before but thats a clever way of avoiding namespace conflicts

@tpoisot tpoisot deleted the branch next September 13, 2024 01:36
@tpoisot tpoisot closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap MultivariateStats
3 participants