Cache whether an update performs a shift, and expose a method to determi... #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -235,6 +235,13 @@ namespace pcl | |||
| PCL_WARN("ICP is %s\n", !disable_icp_?"ENABLED":"DISABLED"); | |||
| } | |||
|
|
|||
| /** \brief Return whether the last update resulted in a shift */ | |||
| bool | |||
| hasShifted () | |||
There was a problem hiding this comment.
Typically we inline and const-qualify getter functions.
|
Updated based on these notes. |
|
Thanks. Could you please squash? Then I'll merge. |
…rmine after an update if a shift occurred.
|
Done. |
taketwo
added a commit
that referenced
this pull request
Oct 8, 2014
Cache whether an update performs a shift, and expose a method to determi...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache whether an update performs a shift, and expose a method to determine after an update if a shift occurred.
We needed a method to reliably determine if a cube shift occurred, and while there is a
checkForShiftmethod inCyclicalBuffer, the call inKinfuTracker::operator()depends on arguments constructed in the method immediately before. To get around this, we can simply cache the result ofCyclicalBuffer::checkForShiftinoperator(), and expose a method to return it.