Preserve viewpoint on sift computation #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PointCloudLibrary#1498. Now the header, sensor_origin and sensor_orientation are copied to the keypoints resultant pointcloud. Added small checks on the tests.
| return (&lhs == &rhs) || | ||
| (lhs.seq == rhs.seq && lhs.stamp == rhs.stamp && lhs.frame_id == rhs.frame_id); | ||
| } | ||
|
|
||
| } // namespace pcl |
There was a problem hiding this comment.
So this is an operator overload for == comparison right?
Why don't you use it then?
There was a problem hiding this comment.
It is implicitly used on the test here, and that is what forced me to define it. I thought that it was probably safer to write the == overload than to make the check on each individual member of the struct on the test. That way, if the struct changes in the future, the editor will know that he needs to update the operator as well, and test will still be valid.
|
👍 apart from what I don't understand, which is probably legitimate. |
|
Thanks for the review 👍 |
|
LGTM. A trivial fix, I think it's safe to include it in 1.8.0. |
VictorLamoine
added a commit
that referenced
this pull request
Jan 26, 2016
Preserve viewpoint on sift computation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1498. Now the header, sensor_origin and sensor_orientation are copied to the keypoints resultant pointcloud. Added small checks on the tests.