[ROS2] Fix DataStreamROS2 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataStreamROS2 plugin was broken for a while in rolling and galactic.
This PR fixes it by migrating from
ros2_parsers/generic_subscription.hpptorclcpp/generic_subscriptionsincegeneric_subscriptionis now part of rclcpp (migrated from rosbag2: ros2/rclcpp#1452)I target once again galactic in this PR. This should not make a difference with rolling at the moment since there was no rolling API breaking changes that I know of impacting this package. However I believe either a new galactic branch should be created, or the current rolling branch should be renamed galactic (and a new rolling or h-turtle would be created closer to the h-turtle release)
I believe plotjuggler is now completely usable for galactic users (at least the features that I am using 😆 ).