Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No header sanity checking in ICODecoder #624

Closed
nagisa opened this issue Feb 24, 2017 · 1 comment
Closed

No header sanity checking in ICODecoder #624

nagisa opened this issue Feb 24, 2017 · 1 comment

Comments

@nagisa
Copy link

nagisa commented Feb 24, 2017

Following base64-encoded ico makes the decoder cause a OOM condition:

AAABAAEAIP//////////EAAAFgAAACgAAABAAAAgEAAAAAEAAQAAAAAAAAAAAAEAAAEAAAAAAAAA
AAAAAAAAAAAB//////8A

This is what file says: MS Windows icon resource - 1 icon, 32x255, 255 colors, 65535 planes, 65535 bits/pixel

Both GIMP and eog handled the file fine by figuring out the file is invalid.
@oyvindln oyvindln mentioned this issue Apr 2, 2017
Merged
@birktj
Copy link
Member

birktj commented May 5, 2019

I am closing this as it should have been addressed in #632.

@birktj birktj closed this as completed May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nagisa @birktj