Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button shortcode alignment #181

Open
ghost opened this issue Dec 3, 2021 · 0 comments
Open

Button shortcode alignment #181

ghost opened this issue Dec 3, 2021 · 0 comments
Labels
invalid This doesn't seem right question Further information is requested

Comments

@ghost
Copy link

ghost commented Dec 3, 2021

$html = '';
if ( !$no_div ) {
$html .= '<div class="' . $alignment . '">';
}

  • Could be nice to have <p> instead of <div> (cleaner semantic)
  • Do we really need a wrapping element like that? Why are we not using the same alignment logic for others elements like it does for text with inline style text-align: left;?
  • Would be nice to have a specific class to identify those button alignment wrappers with a class like class="button-align" so we can set specific rules for button alignment on mobile if we need to.

Prototype: .mce-content-body .wpview.wpview-wrap[data-wpview-type="pip_button"] { display: inline-block; }

@ghost ghost added invalid This doesn't seem right question Further information is requested labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

0 participants