Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edge case with tabs still scrolling to top #230

Merged
merged 1 commit into from
Jan 15, 2022
Merged

Conversation

andreialecu
Copy link
Collaborator

ref #205

@andreialecu andreialecu merged commit dd13cbc into main Jan 15, 2022
@andreialecu andreialecu deleted the fix-scrolltop2 branch January 15, 2022 13:18
@andreialecu
Copy link
Collaborator Author

Released as 4.5.2

@hirbod
Copy link

hirbod commented Jan 15, 2022

@andreialecu it's better but still not 100% fixed.

I have 4 tabs (with prop lazy). As soon as the lazy one loads, it syncs all the other screens.
See following video (i have added indexes to the views):

So there is still an edge case to be handled I guess.
https://streamable.com/h184la

@andreialecu
Copy link
Collaborator Author

Hey @hirbod, I've been refactoring some things over in #255 and I think this may be fixed. Could you give react-native-collapsible-tab-view@5.0.0-rc.3 a try?

See the PR above for prerequisites.

@hirbod
Copy link

hirbod commented May 5, 2022

Will be able to test this in about 2 hours. Does it also handle the issue that happens on android with numColums on FlatList?

@andreialecu
Copy link
Collaborator Author

Not sure, I don't use numColumns but it might.

@hirbod
Copy link

hirbod commented May 6, 2022

@andreialecu I can tell you that I've upgraded and the first thing I realized is that that new release is breaking the swipe behavior in my view. I can only swipe tabs now when I place my finger on the tabs directly or when I swipe in the header area.

It does not play nicely with RectButton by react-native-gesture-handler anymore. It does work with TouchableOpacity though (FlatList with items wrapped in RectButton)

@hirbod
Copy link

hirbod commented May 6, 2022

Found some crashes and regressions @andreialecu
Let's not pollute this old PR anymore:

#256

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants