-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate creation of leafletElement in Path #549
Comments
vadzim
added a commit
to vadzim/react-leaflet
that referenced
this issue
Jan 3, 2019
vadzim
added a commit
to vadzim/react-leaflet
that referenced
this issue
Jan 3, 2019
Oops.. The problem is much more interesting) |
fixed |
vadzim
added a commit
to vadzim/react-leaflet
that referenced
this issue
Jan 3, 2019
PaulLeCam
added a commit
that referenced
this issue
Jan 12, 2019
(#549) Remove duplicate element creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MapLayer
constructor createsleafletElement
in its only statement:react-leaflet/src/MapLayer.js
Line 18 in de369a5
Path
component extendsMapLayer
, callsMapLayer
constructor and then immediately calls the samecreateLeafletElement
function and saves the result to the same fieldleafletElement
:react-leaflet/src/Path.js
Line 40 in de369a5
Actually, the same data is creating twice. There is no need to create
leafletElement
inPath
.The text was updated successfully, but these errors were encountered: