Duplicate creation of leafletElement in Path

[vadzim]

MapLayer constructor creates leafletElement in its only statement:

export default class MapLayer<
...
  constructor(props: Props) {
    super(props)
    this.leafletElement = this.createLeafletElement(props)
}

react-leaflet/src/MapLayer.js

Line 18 in de369a5

this.leafletElement = this.createLeafletElement(props)

Path component extends MapLayer, calls MapLayer constructor and then immediately calls the same createLeafletElement function and saves the result to the same field leafletElement:

export default class Path<...> extends MapLayer<LeafletElement, Props> {
...
  constructor(props: Props) {
    super(props)
    this.leafletElement = this.createLeafletElement(props)
    if (this.contextValue == null) {
      this.contextValue = {
        ...props.leaflet,
        popupContainer: this.leafletElement,
      }
    }
  }

react-leaflet/src/Path.js

Line 40 in de369a5

this.leafletElement = this.createLeafletElement(props)

Actually, the same data is creating twice. There is no need to create leafletElement in Path.

[vadzim]

Oops.. The problem is much more interesting)
Path has a field declaration leafletElement: LeafletElement. This declaration actually assigns undefined to this.leafletElement after calling super(props). The declaration itself was added to make flow check pass.
So it turns that this.leafletElement is created twice only for flow to shut up.

[vadzim]

fixed