-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVGOverlay component #624
Comments
Hi, yes opening a PR for it would be nice, thanks! |
I'm actually running into an issue with the component now: if it is unmounted before the map, I get a |
I realised what I was doing wrong: rendering the |
Now available in v2.5.0 thanks to your PR! |
|
Sorry I forgot to sync the website docs, it's been fixed now. |
Hi @fenech I'm using this component and so far it is very useful!! But.. I'd really appreciate you look into this issues:
|
Hi, I notice that this library doesn't contain a component for Leaflet's SVGOverlay. I made one for my own project - it's written in TypeScript but it would be fairly easy to port to JS/Flow and open a PR if you're interested.
To begin with, I tried to inherit from
MapLayer
, but I decided in the end that I preferred to render thesvg
container in the component, and inherit fromMapComponent
instead.Happy to open a PR if you like, but as a starting point I'll leave the TS code here.
The text was updated successfully, but these errors were encountered: