Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep aspect ratio of images? #62

Open
javiabellan opened this issue Jun 8, 2024 · 1 comment
Open

Keep aspect ratio of images? #62

javiabellan opened this issue Jun 8, 2024 · 1 comment

Comments

@javiabellan
Copy link

I noticed that DKM resizes the image to a fixed size and aspect ratio (horizontal). I think preserving the original aspect ratio of the images could improve performance, especially for extreme image pairs like this one:

BARCELONA -VUNAV-1024x682 2 BARCELONA -VUNAV-1024x682 3

There is any tweak (code modification) to allow this into the current DKM weights?

@Parskatt
Copy link
Owner

Parskatt commented Jun 8, 2024

Yes it possible. And for the pair you show I agree it would probably improve performance.

If you want to dig into the code, the main barriers are

  1. For feature extraction the images are stacked. Instead we need to extract seperately.

  2. In several places I just use "H,W". This needs to be H_A/H_B or something.

In tiny roma (over in the roma repo), I've made these changes. You can refer to the implementation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants