Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize deviceInfo in constructor of ParselyTracker #58

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Initialize deviceInfo in constructor of ParselyTracker #58

merged 2 commits into from
Sep 5, 2023

Commits on Sep 4, 2023

  1. refactor: remove class-wide adKey property 

    It makes codebase easier to understand and eliminates multiple sources
for `parsely_site_uuid`.
    @wzieba
    wzieba committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    98c1dd6 View commit details
    Browse the repository at this point in the history

  2. fix: explicitly create deviceInfo with null adKey 

    This change fixes crash in case of library user running
ParselyTracker#trackPageView (or any other tracking method) **before**
GetAdKey AsyncTask completes.
    @wzieba
    wzieba committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    7621a5a View commit details
    Browse the repository at this point in the history