fix: initialize deviceInfo before putting adKey there #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address NPE crash that happens in
GetAdKey#onPostExecute
.Unfortunately, I wasn't able to reproduce the issue, though I think that provided change will address the problem.
How NPE happens
In the constructor of
ParselyTracker
we, launchGetAdKey
AsyncTask which, in itsonPostExecute
, addsadKey
todeviceInfo
Map.But the
deviceInfo
Map is created afterGetAdKey
is executed. This makes it possible thatdeviceInfo
won't be created beforeGetAdKey
tries to use it - hence the NPE.I wasn't able to reproduce the issue because
GetAdKey#onPostExecute
happens on the main thread, so we have race condition on the main thread, so it's impossible to modify flow viaThread#sleep
.How to test
As we don't have reproduction, please focus on the code - does the proposed change have some side effects? Did I miss something, will it break any other feature?