fix: initialize deviceInfo before putting adKey there #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atorresveiga
reviewed
Jun 5, 2023
| @@ -87,7 +87,6 @@ protected ParselyTracker(String siteId, int flushInterval, Context c) { | |||
| this.rootUrl = "https://p1.parsely.com/"; | |||
| this.queueSizeLimit = 50; | |||
| this.storageSizeLimit = 100; | |||
| this.deviceInfo = this.collectDeviceInfo(); | |||
There was a problem hiding this comment.
The code looks good, @wzieba!
np: I understand that collectDeviceInfo is a map containing the device information. WDYT if instead of creating this map within the post execute of the GetKey task, we keep it in the constructor and move only the get key logic to the postExecute, so the GetAdKey is only responsible for obtaining/saving the key and not for collecting the device info.
There was a problem hiding this comment.
Good point with keeping responsibilities seperately but collectDeviceInfo uses adKey property, which is assigned in GetAdKey, so that's why I moved creation of deviceInfo to GetAdKey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address NPE crash that happens in
GetAdKey#onPostExecute.Unfortunately, I wasn't able to reproduce the issue, though I think that provided change will address the problem.
How NPE happens
In the constructor of
ParselyTrackerwe, launchGetAdKeyAsyncTask which, in itsonPostExecute, addsadKeytodeviceInfoMap.But the
deviceInfoMap is created afterGetAdKeyis executed. This makes it possible thatdeviceInfowon't be created beforeGetAdKeytries to use it - hence the NPE.I wasn't able to reproduce the issue because
GetAdKey#onPostExecutehappens on the main thread, so we have race condition on the main thread, so it's impossible to modify flow viaThread#sleep.How to test
As we don't have reproduction, please focus on the code - does the proposed change have some side effects? Did I miss something, will it break any other feature?