Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated typeguard and deal to latest versions #284

Merged

Conversation

mristin
Copy link
Collaborator

@mristin mristin commented Nov 15, 2023

We have to update the versions so that distributions can package them with the latest dependencies. Originally, we thought that we can simply separate the benchmark dependencies in a separate group in setup.py, but it turned out that some of the tests actually did involve deal and typeguard.

Fixes #282.

We have to update the versions so that distributions can package them
with the latest dependencies. Originally, we thought that we can simply
separate the benchmark dependencies in a separate group in `setup.py`,
but it turned out that some of the tests actually did involve `deal` and
`typeguard`.

Additionally, we also fix the tests for the latest version of typeguard.

Fixes #282.
@mristin mristin force-pushed the mristin/Updated-typeguard-and-deal-to-latest-versions branch from b8e8fa7 to 66ae72b Compare November 15, 2023 13:31
@coveralls
Copy link

Coverage Status

coverage: 92.784%. remained the same
when pulling 66ae72b on mristin/Updated-typeguard-and-deal-to-latest-versions
into 38805f1 on master.

@mristin mristin merged commit dc2e557 into master Nov 15, 2023
12 checks passed
@mristin mristin deleted the mristin/Updated-typeguard-and-deal-to-latest-versions branch November 15, 2023 13:42
mristin added a commit that referenced this pull request Nov 19, 2023
* Updated typeguard and deal to latest versions (#284)

  This change is needed so that distributions can successfully run
  the necessary tests with the development dependencies. Previously,
  the dependencies were outdated, and the old versions were already
  deprecated in distributions (notably, typegard and deal).
@mristin mristin mentioned this pull request Nov 19, 2023
mristin added a commit that referenced this pull request Nov 19, 2023
* Updated typeguard and deal to latest versions (#284)

  This change is needed so that distributions can successfully run
  the necessary tests with the development dependencies. Previously,
  the dependencies were outdated, and the old versions were already
  deprecated in distributions (notably, typegard and deal).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated deal & typeguard
2 participants