Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env var to disable integration providers #9879

Closed
jordanh opened this issue Jun 26, 2024 · 2 comments · Fixed by #9908
Closed

Env var to disable integration providers #9879

jordanh opened this issue Jun 26, 2024 · 2 comments · Fixed by #9908
Assignees
Labels
enhancement Public Sector Work related to the public sector 🇺🇸🫡

Comments

@jordanh
Copy link
Contributor

jordanh commented Jun 26, 2024

Issue - Enhancement

Most deployments at elevated security levels disallow the usage of Jira Cloud vs. Jira Server. Removing this integrations from the product would be beneficial to the user experience. Folks are already clicking Jira Cloud and getting an error when they should be clicking "Jira Server" instead.

Acceptance Criteria (optional)

Admin/SREs can:

  • Set an environment variable that blacklists certain integrations
  • Refer to documentation to tell them what the env var is and how to set it

Estimated effort: 8 points (see CONTRIBUTING.md)

@jordanh jordanh added enhancement Public Sector Work related to the public sector 🇺🇸🫡 labels Jun 26, 2024
@rafaelromcar-parabol
Copy link
Contributor

This could be an opportunity to manage the available integrations per organization or team, instead of per Parabol instance. Using flags in the database. In the future this could even be managed through an admin backoffice or directly by the lead of the organization.

Example using our own SaaS: we also have organizations that use Jira Server instead of Jira Cloud. An enterprise support might want to disable that integration (or any other) from one or more teams.

WDYT?

@Dschoordsch Dschoordsch self-assigned this Jul 1, 2024
@Dschoordsch
Copy link
Contributor

Dschoordsch commented Jul 1, 2024

@rafaelromcar-parabol I think that's a good idea for the future. For this issue however I would say we should do the minimal effort to reach the goal.
Right now we have 2 main ways of adding integrations:

  1. GCal, Azure DevOps, Gitlab and Jira Server are implemented as integration providers and these show up only if they are configured for the instance, organization or team. Usually we configure this via primeIntegration on deployment based on environment variables.
  2. Atlassian Cloud and Slack are always available, even if the environment variables are not set up correctly. Ideally we would convert these to 1., but for now we should just hide the rows if the required OAUTH variables are not set.
  3. Mattermost and Microsoft Teams only work with webhooks and thus don't require any infrastructure setup. These are always available. Unless there is special demand to hide those, I would not touch these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Public Sector Work related to the public sector 🇺🇸🫡
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants