Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon request] battery-profile-performance & battery-profile-powersave #3666

Closed
andrewgrasman opened this issue Mar 10, 2024 · 11 comments
Closed

Comments

@andrewgrasman
Copy link

andrewgrasman commented Mar 10, 2024

These seem to be mentioned in passing in this issue: 3595 but that seems to be a different root issue and not an icon request.

At the moment these Icons seem to be replaced with the default full battery icon (arch papirus and plasma 6 from arch repos), which dons't give the information it should and looks kinda bad. This is visible when you click the default battery applet with power-profiles-daemon installed and enabled.

What it currently looks like:
image

What it should look like (from breeze):
Screenshot_20240310_162528

@morganist
Copy link
Contributor

morganist commented Apr 21, 2024

#3665

@morganist
Copy link
Contributor

@andrewgrasman can you please confirm that the icons are now correct? I don't have a laptop with Plasma.

@andrewgrasman
Copy link
Author

@morganist It seems to be pretty good, only difference is it's staying at a larger size for me than before using the default battery icon.

@morganist
Copy link
Contributor

@andrewgrasman is it the the baterry profile icons that are staying at a larger size? can you please attach a screenshot, if possible?

@andrewgrasman
Copy link
Author

Ok I have gotten a lot of screenshots for details, I'm on wayland with 100% scaling and a panel height of 40.

Previously when plugged in:
Screenshot_20240429_200335

Previously when unplugged:
Screenshot_20240429_200346


Currently when unplugged no matter power profile:
Screenshot_20240429_200619

Currently when plugged in and all three profiles:
Screenshot_20240429_200641
Screenshot_20240429_200649
Screenshot_20240429_200655

@morganist
Copy link
Contributor

oh, i see. can you please check if the power applet is inside the margins separator, like the system tray? if it's not, Plasma will stretch it to panel width, which seems like it does on your screenshot. doesn't seem like a scaling issue.

@andrewgrasman
Copy link
Author

It is the standalone aplet, I prefer it over the one in the tray.

@morganist
Copy link
Contributor

morganist commented Apr 30, 2024

@andrewgrasman let me give you an example: in the edit mode, you can see the panel margins and how applets set their width based on which side of the separator they are on. what I'm saying is you should drag your standalone power applet inside the narrow side of the margin separator, like I should drag my media player applet to the right in my example. if you don't have a margins separator on your panel, add one - it's supposed to solve exactly this issue.

image

@andrewgrasman
Copy link
Author

image

I don't think margin separators are quite what I want

@morganist
Copy link
Contributor

morganist commented May 4, 2024

@andrewgrasman look, the icon is now correctly sized at 22px. the only problem is that half of it is obscured by percentage, isn't it? but margin separators solve the sizing issue like they should, so... can you customise the percentage display? for example, for it to be next to the icon, not in it? i haven't used a laptop with plasma before.

also, you colud put the system tray inside these two separators to avoid a large gap between it and the battery indicator.

@andrewgrasman
Copy link
Author

It doesn't bother me, I just think knowing that this icon change changed how sizing works for this theme is notable for development purposes. Sorry for coming off a little rude in my last reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants