【Hackathon No.7】为 Paddle 新增 apply API rfcs #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
此实现方案当前只能在CPU上运行，是否应该支持GPU运行，以及如何支持需要论证 |
|
按照API实现规范，要同时支持动态图和静态图，在静态图如何实现，也需要说明 |
|
@luotao1 @jeff41404 老师您好，我已经尝试添加了对于新旧 ir 静态图的支持，麻烦再review下吧。 |
jeff41404
reviewed
Dec 14, 2023
| ) | ||
| self._apply_(func) | ||
|
|
||
| @framework.dygraph_only |
There was a problem hiding this comment.
如果要支持静态图，就不能用这个装饰器吧，且其中需要有静态图的分支
jeff41404
reviewed
Dec 14, 2023
| return self._apply(func) | ||
| ``` | ||
|
|
||
| C++ 端则是在 eager_method.cc 中增加相应的逻辑，可以复用 PyTensorHook 来对 tensor 作用 callable python function。 |
There was a problem hiding this comment.
如果Tensor在CPU上，这样做是可以的；但如果Tensor在GPU上，这样实现是否能运行，需要说明
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.