Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 5th No.22】为Paddle新增 CosineAnnealingWarmRestarts API RFC #649

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

Patrick-Star125
Copy link
Contributor

新增 CosineAnnealingWarmRestarts API 设计文档

@paddle-bot
Copy link

paddle-bot bot commented Sep 25, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@Patrick-Star125 Patrick-Star125 changed the title 【Hackathon 5th No.22】为 CosineAnnealingWarmRestarts 新增 API RFC 【Hackathon 5th No.22】为Paddle新增 CosineAnnealingWarmRestarts API RFC Sep 25, 2023
@@ -0,0 +1,223 @@
# paddle.CosineAnnealingWarmRestarts 设计文档
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

标题中的API路径需要和下面的API名称一致

paddle.optimizer.lr.CosineAnnealingWarmRestarts
----------------------
参数
:::::::::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些冒号是否有必要

参数
:::::::::

- `leaning_rates` - 初始化的学习率
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是learning_rate ?和已有其它API保持一致,同时看下面的示例代码中也是 learning_rate

@Patrick-Star125
Copy link
Contributor Author

已修改

Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 merged commit 45ee13e into PaddlePaddle:master Oct 12, 2023
1 check passed
yangguohao pushed a commit to yangguohao/community that referenced this pull request Oct 22, 2023
…addlePaddle#649)

* add 20230925_api_design_for_CosineAnnealingWarmRestarts.md

* regulate formation

* regulate formation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants