[CINN] Add more rules to cinn_to_pd_op pass #64354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
approved these changes
May 17, 2024
| ::pir::IrMapping& ir_mapping, // NOLINT | ||
| ::pir::Builder& builder) { // NOLINT | ||
| VLOG(6) << "transform " << op->name() << " from cinn_op to pd_op"; | ||
| auto attrs = op->attributes(); |
There was a problem hiding this comment.
Suggested change
| auto attrs = op->attributes(); | |
| const auto& attrs = op->attributes(); |
避免map的copy
| VLOG(6) << "transform " << op->name() << " from cinn_op to pd_op"; | ||
| auto attrs = op->attributes(); | ||
|
|
||
| float scale = attrs.at("scale").dyn_cast<::pir::FloatAttribute>().data(); |
There was a problem hiding this comment.
Suggested change
| float scale = attrs.at("scale").dyn_cast<::pir::FloatAttribute>().data(); | |
| const float scale = attrs.at("scale").dyn_cast<::pir::FloatAttribute>().data(); |
可以养成const的习惯
| ::pir::IrMapping& ir_mapping, // NOLINT | ||
| ::pir::Builder& builder) { // NOLINT | ||
| VLOG(6) << "transform " << op->name() << " from cinn_op to pd_op"; | ||
| auto attrs = op->attributes(); |
There was a problem hiding this comment.
同上，对于不需要修改attrs的转换规则，建议使用const &，下面的函数也可以系统性看下
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 18, 2024
* add more rules to cinn_to_pd_op pass * update
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 19, 2024
* add more rules to cinn_to_pd_op pass * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
Pcard-67164
为cinn op到pd op的转换添加更多规则