Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 6th Fundable Projects 3 No.1、3、26、57、66、72、105、115-117、173-174、188、215、228-229、244、253、272、303、309、317、325、329、355、357-358、365、367、369、373、386、390】Remove fluid prim_ops #63399

Merged
merged 9 commits into from
Apr 16, 2024
Merged

【Hackathon 6th Fundable Projects 3 No.1、3、26、57、66、72、105、115-117、173-174、188、215、228-229、244、253、272、303、309、317、325、329、355、357-358、365、367、369、373、386、390】Remove fluid prim_ops #63399

merged 9 commits into from
Apr 16, 2024

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Apr 10, 2024

PR Category

Others

PR Types

Others

Description

Remove fluid prim_ops

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Apr 10, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 10, 2024
wanghuancoder
wanghuancoder previously approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 请 @luotao1 协调留杰、陈晓旭帮忙Review一下。

@luotao1 luotao1 mentioned this pull request Apr 12, 2024
Closed
XieYunshen
XieYunshen previously approved these changes Apr 12, 2024
View reviewed changes
Aurelius84
Aurelius84 previously approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@luotao1
Copy link
Contributor

luotao1 commented Apr 12, 2024 


2024-04-12 14:27:13 ========================================
2024-04-12 14:27:13 The following tests FAILED: 
2024-04-12 14:27:13 	2888 - test_prim_dist_op (Failed)
2024-04-12 14:27:13             	2888 - test_prim_dist_op (Failed)
2024-04-12 14:27:13 + EXCODE=8

@co63oc
Copy link
Contributor Author

co63oc commented Apr 13, 2024

@luotao1 已删除 test_prim_dist_op 单测，CI已完成

cxxly
cxxly previously approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@cxxly cxxly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XieYunshen
XieYunshen previously approved these changes Apr 15, 2024
View reviewed changes
@co63oc co63oc dismissed stale reviews from XieYunshen and cxxly via d5c1f8b April 15, 2024 10:02
@co63oc
Copy link
Contributor Author

co63oc commented Apr 15, 2024 •
edited
Loading

这个PR CI-Coverage不明确，其他CI没有测试到问题，建议通过CI-Coverage再review @luotao1

@luotao1
Copy link
Contributor

luotao1 commented Apr 16, 2024

  • 这个是由于原来设定的规则（原则上不能删除单测，避免RD删单侧来通过CI），所以Coverage检查时如果删了单测，得QA approve。approve后再跑所有的单测。
  • 因为几乎99%的开发都不会删单侧，所以也辛苦你理解下这里的流程。

@co63oc co63oc changed the title 【Hackathon 6th Fundable Projects 3 No.1、3】Remove fluid prim_ops 【Hackathon 6th Fundable Projects 3 No.1、3、26、57、66、72、105、115-117、173-174、188、215、228-229、244、253、272、303、309、317、325、329、355、357-358、365、367、369、373、386、390】Remove fluid prim_ops Apr 16, 2024
@luotao1 luotao1 merged commit 4e08c87 into PaddlePaddle:develop Apr 16, 2024
29 checks passed
Asthestarsfalll pushed a commit to Asthestarsfalll/Paddle that referenced this pull request Apr 17, 2024
@co63oc @Asthestarsfalll
【Hackathon 6th Fundable Projects 3 No.1、3、26、57、66、72、105、115-117、173…
c625565 
…-174、188、215、228-229、244、253、272、303、309、317、325、329、355、357-358、365、367、369、373、386、390】Remove fluid prim_ops (PaddlePaddle#63399)
@co63oc co63oc deleted the fixprim2 branch April 27, 2024 22:44
@SigureMo SigureMo mentioned this pull request Jul 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XieYunshen XieYunshen XieYunshen approved these changes

@cxxly cxxly cxxly left review comments

@Aurelius84 Aurelius84 Aurelius84 left review comments

@wanghuancoder wanghuancoder wanghuancoder left review comments

Assignees

@luotao1 luotao1

@wanghuancoder wanghuancoder

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@co63oc @luotao1 @cxxly @Aurelius84 @wanghuancoder @XieYunshen