Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 6th Fundable Projects 3 No.334】Remove fluid operator sequence_concat #63235

Merged
merged 2 commits into from
Apr 16, 2024
Merged

【Hackathon 6th Fundable Projects 3 No.334】Remove fluid operator sequence_concat #63235

merged 2 commits into from
Apr 16, 2024

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Apr 4, 2024

PR Category

Others

PR Types

Others

Description

Remove fluid operator sequence_concat

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Apr 4, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 4, 2024
@co63oc co63oc changed the title Remove fluid operator sequence_concat 【Hackathon 6th Fundable Projects No.3】Remove fluid operator sequence_concat - part Apr 4, 2024
wanghuancoder
wanghuancoder previously approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wanghuancoder
wanghuancoder reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是永康提供的明确可以删除的算子对吧？因为删除了Python API，属于不兼容升级。

@co63oc
Copy link
Contributor Author

co63oc commented Apr 8, 2024

这个是永康提供的明确可以删除的算子对吧？因为删除了Python API，属于不兼容升级。

是的删除列表中的算子

@co63oc co63oc mentioned this pull request Apr 8, 2024
Closed
@co63oc co63oc changed the title 【Hackathon 6th Fundable Projects No.3】Remove fluid operator sequence_concat - part 【Hackathon 6th Fundable Projects 3 No.334】Remove fluid operator sequence_concat - part Apr 8, 2024
@co63oc co63oc changed the title 【Hackathon 6th Fundable Projects 3 No.334】Remove fluid operator sequence_concat - part 【Hackathon 6th Fundable Projects 3 No.334】Remove fluid operator sequence_concat Apr 12, 2024
wanghuancoder
wanghuancoder approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 请 @luotao1 推动合入

@luotao1 luotao1 merged commit c802fac into PaddlePaddle:develop Apr 16, 2024
29 checks passed
Asthestarsfalll pushed a commit to Asthestarsfalll/Paddle that referenced this pull request Apr 17, 2024
@co63oc @Asthestarsfalll
【Hackathon 6th Fundable Projects 3 No.334】Remove fluid operator sequ…
792d128 
…ence_concat (PaddlePaddle#63235)
@co63oc co63oc deleted the fixseq branch May 29, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

Assignees

@luotao1 luotao1

@wanghuancoder wanghuancoder

@XieYunshen XieYunshen

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@co63oc @wanghuancoder @XieYunshen @luotao1