[PIR][oneDNN] Add reshape_transpose_matmul_fuse_pass #62998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
LLee233
force-pushed
the
reshape_transpose_matmul
branch
4 times, most recently
from
bc8ce1d
to
7e9344e
Compare
|
Hi @vivienfanghuagood @yuanlehome , 这个PR的CI已经全部pass了，可以麻烦帮review一下吗？Thx~ |
yuanlehome
reviewed
Apr 2, 2024
Comment on lines
25
to
28
| @unittest.skipIf( | ||
| not paddle.base.core.is_compiled_with_mkldnn(), | ||
| "Test case only for OneDNN pass.", | ||
| ) |
There was a problem hiding this comment.
onednn里的pass单测是不需要加这个skipif的，当WITH_MKLDNN为OFF时，相关Pass是不会加入单测列表的，其他Pass可以一并梳理并删除下
There was a problem hiding this comment.
但这个我之前有case没加，结果inference CI 过不了。。。应该是因为pass没注册，但这个case会跑且调用了相应的pass
There was a problem hiding this comment.
好的，那我直接update在这个PR里啦~
LLee233
force-pushed
the
reshape_transpose_matmul
branch
from
2329c51
to
b2b606e
Compare
yuanlehome
reviewed
Apr 2, 2024
Comment on lines
1
to
4
| add_subdirectory(onednn) | ||
| if(WITH_MKLDNN) | ||
| add_subdirectory(onednn) | ||
| endif() |
xinyu-intel
approved these changes
Apr 3, 2024
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Others
PR Types
New features
Description
Based on new pass mechanism, here we add pass "reshape_transpose_matmul_fuse_pass" for PIR.
The new pass is same as "reshape_transpose_matmul_mkldnn_fuse_pass" in "/paddle/fluid/framework/ir/mkldnn/reshape_transpose_matmul_mkldnn_fuse_pass.cc"
Also, to extend the capability of matmul_elementwise_add_fuse_pass, we here add new pattern for it.