[PIR AMP]Split tracer and amp attr #61297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuanRisheng
approved these changes
Jan 31, 2024
| std::string GetAmpDtype() const; | ||
| void SetAmpDtype(std::string amp_dtype); | ||
| phi::DataType GetAmpPhiDtype() const; | ||
| // void Reset(); |
zyfncg
approved these changes
Jan 31, 2024
zhangbo9674
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-67164
本PR是PIR下支持AMP训练的第一个PR，主要完成tracer和AMP训练相关属性的解绑工作，具体来说：
NOTE：
PR中将tracer中的use_promote_、amp_level_、amp_dtype_属性放到了AMPState，但是在tracer中依然保留了GetUsePromote、SetAmpLevel、GetAmpDtype等相关的接口，本PR修改之后tracer的这些接口内部会调用AMPState对应的接口。为什么没有删除tracer的相关接口？不管是python端还是cpp端还有调用tracer这些相关的接口，这里没有删除只是为了加快PIR AMP功能开发进度，这里作为一个TODO项后面会单独提一个PR或者协调外部开发者来完成这部分清理清理工作。需要清理的相关接口包括但不限于：
对于AmpOperators也是同理，比较好的状态应该是将AmpOperators和AMPState合并，后面也会单独提PR处理