Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SOT] Move internal functions to a separate file #61143

Merged
merged 1 commit into from
Jan 25, 2024
Merged

[SOT] Move internal functions to a separate file #61143

merged 1 commit into from
Jan 25, 2024

Conversation

SigureMo
Copy link
Member

PR types

Others

PR changes

Others

Description

拆分 eval_frame.c，将从 cpython copy 的 internal functions 移到 cpython_internals.c

PCard-66972

@SigureMo SigureMo requested a review from gouzil January 24, 2024 13:14
gouzil
gouzil approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@gouzil gouzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit 417a49f into PaddlePaddle:develop Jan 25, 2024
29 of 30 checks passed
@SigureMo SigureMo deleted the sot/move-internal-fns-to-a-separate-file branch January 25, 2024 00:45
@gouzil gouzil mentioned this pull request Jan 25, 2024
Merged
eee4017 pushed a commit to eee4017/Paddle that referenced this pull request Jan 30, 2024
@SigureMo @eee4017
[SOT] Move internal functions to a separate file (PaddlePaddle#61143)
8e75d3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouzil gouzil gouzil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SigureMo @gouzil