[PIR] add python api for if #60895
Merged
[PIR] add python api for if #60895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
winter-wang
force-pushed
the
ir_develop
branch
4 times, most recently
from
9a8ef41
to
7027952
Compare
winter-wang
force-pushed
the
ir_develop
branch
from
7027952
to
ffbfbba
Compare
zhangbo9674
reviewed
Jan 22, 2024
| cond = cpu_cond.data<bool>()[0]; | ||
| #else | ||
| PADDLE_THROW(paddle::platform::errors::PreconditionNotMet( | ||
| "This version of PaddlePaddle does NOT support GPU/XPU but got " |
There was a problem hiding this comment.
does NOT support GPU/XPU ？
There was a problem hiding this comment.
这个目前是跟while的判定逻辑对齐的。
| auto& cond_array = cond_var_->Get<VariableRefArray>(); | ||
| cond = std::all_of( | ||
| cond_array.begin(), cond_array.end(), [](const Variable* t) { | ||
| return t->Get<phi::DenseTensor>().numel() != 0; |
There was a problem hiding this comment.
t 一定是 DenseTensor么，最好加一个检查？另外这里的判断逻辑就是要用tensor 的 numel 来判断么？
There was a problem hiding this comment.
这个是复制的原始的condition_block.cc中的执行逻辑。我理解是只支持为densorTensor的情况。如果不是densorTensor， 在Getphi::DenseTensor()这句话里面会有错误提示。
zhangbo9674
approved these changes
Jan 22, 2024
risemeup1
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Other
Pcard-67164