[XPU] add some bf16 ops for kl3 #59263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
QingshuChen
reviewed
Nov 23, 2023
| @@ -31,16 +31,17 @@ float GetAbsMax(const Context& dev_ctx, | |||
| const float* input, | |||
| float* buffer_xpu, | |||
| int64_t numel) { | |||
| float buffer_cpu[6]; | |||
| int max_ptr_size = phi::backends::xpu::get_xpu_max_ptr_size(-1); | |||
| float buffer_cpu[12]; // 12 is enough even for XPU3 | |||
There was a problem hiding this comment.
显存足够的话很可能不需要了，但是也留着以防万一。不刷那个环境变量就不会启动。
QingshuChen
approved these changes
Nov 23, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Description
AdamW里面有一个获得最大值的临时空间，在kl2和kl3下面findmax函数返回的结果个数不同，因此换了写法。