【CINN】Add device query components for cinn #58988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZzSean
reviewed
Nov 15, 2023
paddle/cinn/common/dev_info_base.h
Outdated
| @@ -0,0 +1,26 @@ | |||
| // Copyright (c) 2021 CINN Authors. All Rights Reserved. | |||
ZzSean
reviewed
Nov 16, 2023
paddle/cinn/common/nvgpu_dev_info.h
Outdated
| class NVGPUDevInfo : public DevInfoBase { | ||
| public: | ||
| explicit NVGPUDevInfo(int device) : device_num_(device) { | ||
| #ifdef CINN_WITH_CUDA |
There was a problem hiding this comment.
该文件内是nvgpu的device信息，感觉可以在编译时期就确定此文件是否编译（-DCINN_WITH_CUDA=ON or OFF），不用到处加这个宏判断？
ZzSean
reviewed
Nov 16, 2023
| int device_num = 0); | ||
|
|
||
| Target::Arch arch_; | ||
| int device_num_; |
There was a problem hiding this comment.
主要混合设备下不同架构的接口不同，如果异构的情况下，几个设备放在一块感觉Get的时候会比较乱，如果是同种设备，get其中一个也就OK了，所以就没搞这事
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* add device query components for cinn * fix include file path bug * refactor code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
pcard-72718
This PR add device-query component for CINN