Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRR] Create PatternRewritePass in pass.h #58655

Merged
merged 12 commits into from
Nov 15, 2023

Conversation

gongshaotian
Copy link
Contributor

@gongshaotian gongshaotian commented Nov 3, 2023

PR types

New features

PR changes

APIs

Description

  1. 简化 Rewrite Pattern 类型的 PASS 编写方式,对于Run()和 Initialize() 提供一套默认实现。
  2. 将现有的 Rewrite Pattern 类型的 PASS 替换成继承 PatternRewritePass 的实现

Pcard-67164

Copy link

paddle-bot bot commented Nov 3, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@gongshaotian gongshaotian changed the title [DRR] Create DrrBasePass API [DRR] Create PatternPass in pass.h Nov 6, 2023
paddle/pir/pass/pass.h Outdated Show resolved Hide resolved
paddle/pir/pass/pass.h Outdated Show resolved Hide resolved
test/cpp/pir/pattern_rewrite/drr_test.cc Outdated Show resolved Hide resolved
paddle/pir/pass/pass.h Outdated Show resolved Hide resolved
paddle/pir/pass/pass.h Outdated Show resolved Hide resolved
paddle/fluid/pir/drr/api/drr_base_pass.h Outdated Show resolved Hide resolved
paddle/pir/pass/pass.h Outdated Show resolved Hide resolved
zyfncg
zyfncg previously approved these changes Nov 6, 2023
@gongshaotian gongshaotian changed the title [DRR] Create PatternPass in pass.h [DRR] Create PatternRewritePass in pass.h Nov 7, 2023
Copy link
Contributor

@yuanlehome yuanlehome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuanlehome yuanlehome merged commit 03e59e4 into PaddlePaddle:develop Nov 15, 2023
28 checks passed
@gongshaotian gongshaotian deleted the drr_rewriteBase branch November 20, 2023 10:58
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
* create class DrrBasePass

* add PatternPass in pass.h

* Change the RewritePattern type pass from inheriting Pass to inheriting PatternPass

* Rename PatternPass as PatternRewritePass and delete CanApplyOn() func

* fix bug

* Fix compilation bugs

* fix bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants