[PIR]Migrate Conv2DTranspose into pir #58416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
0x45f
commented
Oct 31, 2023
| def runTest(self): | ||
| place = base.CPUPlace() | ||
| self._test_equivalence(place) | ||
|
|
||
| if base.core.is_compiled_with_cuda(): |
There was a problem hiding this comment.
在self._test_equivalence函数内会重新设置place为CPUPlace，所以这个case相当于跑了两次CPU测试。如果跑GPU测试的话在CI上会有精度问题，所以在这个PR中删除了GPU的测试代码。
YuanRisheng
approved these changes
Nov 2, 2023
| self.check_output_with_place( | ||
| place, | ||
| atol=1e-5, | ||
| check_dygraph=(not self.use_mkldnn), |
There was a problem hiding this comment.
感觉如果是mkldnn单测的话，这里是不是没有啥意义
There was a problem hiding this comment.
子类既然是单独去测mkldnn的，那copy过来的代码继续加check_dygraph=(not self.use_mkldnn)本身没啥意义，是不是应该默认就关闭check dygraph的检查呢，不然会对后边看到代码的人造成困扰
Aurelius84
approved these changes
Nov 2, 2023
phlrain
approved these changes
Nov 2, 2023
zeroRains
pushed a commit
to zeroRains/Paddle
that referenced
this pull request
Nov 8, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
[PIR]Migrate Conv2DTranspose into pir
涉及到两个相关单测的修改
Pcard-67164