[PIR]Support PassStopGradients mechanism and Set stop_gradient as True #57255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
requested review from
zhangbo9674,
YuanRisheng,
cyber-pioneer and
xiaoguoguo626807
Aurelius84
changed the title
YuanRisheng
previously approved these changes
Sep 13, 2023
cyber-pioneer
previously approved these changes
Sep 13, 2023
Aurelius84
dismissed stale reviews from cyber-pioneer and YuanRisheng
via
3b29e1e
YuanRisheng
previously approved these changes
Sep 14, 2023
YuanRisheng
approved these changes
Sep 15, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
PaddlePaddle#57255) * [PIR]Set stop_gradient as True and is_persistable as False * add PassStopGradients for build op * fix unittest * fix lint * fix uint32_t * fix ut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-67164
对于一个Op，只要它其中一个输入的stop_gradient = False，则其输出的stop_gradient 就应该为 False.
TODO: 是否需要特殊处理一批本身无梯度定义的输出，比如Index_xx类的算子，其返回的index本身是没有梯度的。