Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 5th No.116】paddle.quantile/nanquantile 功能增强 #56461

Closed
wants to merge 29 commits into from
Closed

【Hackathon 5th No.116】paddle.quantile/nanquantile 功能增强 #56461

wants to merge 29 commits into from

Conversation

Asthestarsfalll
Copy link
Contributor

@Asthestarsfalll Asthestarsfalll commented Aug 19, 2023 •
edited
Loading

PR types

Function optimization

PR changes

APIs

Description

docs: PaddlePaddle/docs#6353

@paddle-bot
Copy link

paddle-bot bot commented Aug 19, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 19, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 21, 2023
@luotao1 luotao1 mentioned this pull request Aug 21, 2023
Closed
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Aug 29, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Aug 29, 2023
@luotao1
Copy link
Contributor

luotao1 commented Aug 30, 2023

test_quantile_and_nanquantile (Failed) 需要修复下单测

luotao1
luotao1 reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测覆盖率不够，辛苦再增加下
image

zhwesky2010
zhwesky2010 reviewed Sep 5, 2023
View reviewed changes
python/paddle/tensor/stat.py Outdated Show resolved Hide resolved
test/legacy_test/test_quantile_and_nanquantile.py Outdated Show resolved Hide resolved
@Asthestarsfalll
Copy link
Contributor Author

@zhwesky2010 辛苦再看下～

@luotao1
Copy link
Contributor

luotao1 commented Nov 14, 2023

@Asthestarsfalll 需要过一下Codestyle流水线

@paddle-ci-bot Paddle-ci-bot
Copy link

paddle-ci-bot bot commented Nov 16, 2023

Sorry to inform you that edba2f1's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@Asthestarsfalll Asthestarsfalll mentioned this pull request Dec 6, 2023
Open
@luotao1
Copy link
Contributor

luotao1 commented Dec 6, 2023

PR标题得改成黑客松题目格式

@Asthestarsfalll Asthestarsfalll changed the title [quantile/nanquantile]易用性提升 No.20 【Hackathon 5th No.113】paddle.quantile/nanquantile 功能增强 Dec 6, 2023
@luotao1 luotao1 changed the title 【Hackathon 5th No.113】paddle.quantile/nanquantile 功能增强 【Hackathon 5th No.116】paddle.quantile/nanquantile 功能增强 Dec 7, 2023
@luotao1
Copy link
Contributor

luotao1 commented Dec 7, 2023

image @Asthestarsfalll

@Asthestarsfalll
Copy link
Contributor Author

image @Asthestarsfalll

已修改

@Asthestarsfalll
Copy link
Contributor Author

@zhwesky2010 麻烦再看下～

zhwesky2010
zhwesky2010 reviewed Dec 12, 2023
View reviewed changes
test/legacy_test/test_quantile_and_nanquantile.py
paddle_res_fp64, np_res_fp64, rtol=1e-05
)

def test_static_0d_tensor(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

静态图1D测试了吗？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_static_tensor 测试了1d静态图

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Dec 21, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Dec 21, 2023
@luotao1 luotao1 closed this Mar 20, 2024
@Asthestarsfalll Asthestarsfalll deleted the quantile branch March 20, 2024 03:30
@Asthestarsfalll Asthestarsfalll restored the quantile branch March 21, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 left review comments

@zhwesky2010 zhwesky2010 Awaiting requested review from zhwesky2010

Assignees

@luotao1 luotao1

@zhwesky2010 zhwesky2010

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Asthestarsfalll @luotao1 @zhwesky2010