【new ir】add ir pybind api #55745
Merged
【new ir】add ir pybind api #55745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
tianshuo78520a
approved these changes
Jul 28, 2023
YuanRisheng
reviewed
Jul 28, 2023
paddle/fluid/pybind/ir.cc
Outdated
| @@ -64,6 +64,8 @@ void BindProgram(py::module *m) { | |||
| void BindBlock(py::module *m) { | |||
| py::class_<Block> block(*m, "Block"); | |||
| block.def("front", &Block::front, return_value_policy::reference) | |||
| .def("get_program", | |||
paddle/fluid/pybind/ir.cc
Outdated
| @@ -81,9 +83,11 @@ void BindBlock(py::module *m) { | |||
| void BindOperation(py::module *m) { | |||
| py::class_<Operation> op(*m, "Operation"); | |||
| op.def("name", &Operation::name) | |||
| .def("get_parent", &Operation::GetParent, return_value_policy::reference) | |||
| .def("get_block", &Operation::GetParent, return_value_policy::reference) | |||
paddle/fluid/pybind/ir.cc
Outdated
| .def("result", &Operation::result) | ||
| .def("operand", &Operation::op_operand) |
There was a problem hiding this comment.
修改c++端op_operand命名为operand
YuanRisheng
previously approved these changes
Jul 28, 2023
zhangbo9674
previously approved these changes
Jul 28, 2023
xiaoguoguo626807
dismissed stale reviews from Aurelius84, winter-wang, zhangbo9674, and YuanRisheng
via
c9eb1f9
xiaoguoguo626807
force-pushed
the
pybind
branch
from
e23e74a
to
94b3930
Compare
zhangbo9674
approved these changes
Aug 1, 2023
chenwhql
approved these changes
Aug 1, 2023
| for opresult in matmul_op.results(): | ||
| result_set.add(opresult) | ||
|
|
||
| # self.assertTrue(add_op.operands()[0].source() in result_set) |
There was a problem hiding this comment.
这里是否还需要？注释代码如果还需要，建议也加注释说明
There was a problem hiding this comment.
这些代码依赖一些实现，下一个pr会解掉注释
Ligoml
approved these changes
Aug 1, 2023
jeff41404
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
pcard-67164
增加部分pybind 接口
修改c++ operand 函数的 op_operand 为 operand ; operand 为 operand_source , 以明确返回值语义