Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] add libxsmm,lite,openblas third_party cache #54380

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jun 6, 2023

PR types

Others

PR changes

Others

Description

#54305 2.2
add libxsmm, lite, openblas

@paddle-bot
Copy link

paddle-bot bot commented Jun 6, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 6, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 7, 2023
.gitmodules Outdated Show resolved Hide resolved
@enkilee enkilee changed the title [cmake] add libxsmm,lite,openblas,rocksdb third_party cache [cmake] add libxsmm,lite,openblas third_party cache Jun 8, 2023
@enkilee
Copy link
Contributor Author

enkilee commented Jun 19, 2023

@risemeup1 please verify , thx

@risemeup1
Copy link
Contributor

@risemeup1 please verify , thx

好的

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jun 23, 2023

Sorry to inform you that b6af9a3's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@enkilee
Copy link
Contributor Author

enkilee commented Jun 27, 2023

@risemeup1 有空麻烦审核下,谢谢

@enkilee enkilee requested a review from risemeup1 June 28, 2023 06:57
risemeup1
risemeup1 previously approved these changes Jun 29, 2023
@risemeup1
Copy link
Contributor

@risemeup1 有空麻烦审核下,谢谢

Coverage没过啊

@luotao1
Copy link
Contributor

luotao1 commented Jun 30, 2023

@enkilee 要不merge下develop吧,rerun后这两条流水线也没过

@enkilee
Copy link
Contributor Author

enkilee commented Jun 30, 2023

收到

@luotao1
Copy link
Contributor

luotao1 commented Jul 4, 2023

Coverage一直没过,要不把 libxsmm, lite, openblas 拆开来提PR,看具体是哪个第三方库出问题。

@risemeup1
Copy link
Contributor

Coverage一直没过,要不把 libxsmm, lite, openblas 拆开来提PR,看具体是哪个第三方库出问题。

image
这个是lite.cmake路径的问题,路径没改过来

@risemeup1
Copy link
Contributor

Coverage一直没过,要不把 libxsmm, lite, openblas 拆开来提PR,看具体是哪个第三方库出问题。

image
这里要改一下路径

@enkilee
Copy link
Contributor Author

enkilee commented Jul 4, 2023

收到

@luotao1
Copy link
Contributor

luotao1 commented Jul 17, 2023

@risemeup1 商量了下:

  • 本PR先把libxsmm和openblas 合进去,辛苦 @enkilee 更新下PR通过CI
  • lite的修改后续将由 @risemeup1 来收尾

@enkilee
Copy link
Contributor Author

enkilee commented Jul 17, 2023

收到

Copy link
Contributor

@risemeup1 risemeup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit e64e1b9 into PaddlePaddle:develop Jul 18, 2023
cqulilujia pushed a commit to cqulilujia/Paddle that referenced this pull request Jul 24, 2023
* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* remove rocksdb change

* fix

* fix

* fix

* fix lite

* fix

* Update lite.cmake

---------

Co-authored-by: risemeup1 <62429225+risemeup1@users.noreply.github.com>
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* remove rocksdb change

* fix

* fix

* fix

* fix lite

* fix

* Update lite.cmake

---------

Co-authored-by: risemeup1 <62429225+risemeup1@users.noreply.github.com>
@enkilee enkilee deleted the Supports-offline-compilation-of-Paddle-third-party-libraries branch December 19, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants