Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XPU] update log for bkcl function calls. #53609

Merged
merged 5 commits into from
May 11, 2023
Merged

[XPU] update log for bkcl function calls. #53609

merged 5 commits into from
May 11, 2023

Conversation

houj04
Copy link
Contributor

@houj04 houj04 commented May 8, 2023 •
edited
Loading

PR types

New features

PR changes

Others

Description

  • 修改BKCL库调用时候的日志，追加更多信息，方便debug。
  • 顺便删除了FusedGemmEpilogueXPUKernel里面一处不需要的高级别日志。

@paddle-bot
Copy link

paddle-bot bot commented May 8, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented May 8, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

XiaociZhang
XiaociZhang reviewed May 8, 2023
View reviewed changes
Copy link
Contributor

@XiaociZhang XiaociZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaociZhang
XiaociZhang reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@XiaociZhang XiaociZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for now, could be removed in future

ykkk2333
ykkk2333 approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@ykkk2333 ykkk2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RuohengMa
RuohengMa approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@RuohengMa RuohengMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 merged commit d67d74c into PaddlePaddle:develop May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaociZhang XiaociZhang XiaociZhang left review comments

@QingshuChen QingshuChen QingshuChen approved these changes

@ykkk2333 ykkk2333 ykkk2333 approved these changes

@RuohengMa RuohengMa RuohengMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@houj04 @QingshuChen @ykkk2333 @XiaociZhang @RuohengMa