Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.91】Following updates #53572

Merged
merged 1 commit into from
May 8, 2023
Merged

【Hackathon No.91】Following updates #53572

merged 1 commit into from
May 8, 2023

Conversation

yangguohao
Copy link
Contributor

@yangguohao yangguohao commented May 7, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

Following update of register_hook for static mode

@paddle-bot
Copy link

paddle-bot bot commented May 7, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels May 7, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 7, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@yangguohao yangguohao mentioned this pull request May 7, 2023
Merged
@yangguohao
Copy link
Contributor Author

根据上个 PR 最后的修改意见更新：

  1. 通过 Transformer 的形式进行修改，并且逻辑都移动 tensorhook_transformer.py 和 ast_transformer.py 中。
  2. 修改测试文件为 np.testing.assert_allclose

Aurelius84
Aurelius84 approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit f3f3d57 into PaddlePaddle:develop May 8, 2023
@yangguohao yangguohao deleted the static_hook_2 branch September 18, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangguohao @luotao1 @Aurelius84