Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CustomOP Inplace] Add customOP inplace check #51844

Merged
merged 2 commits into from
Mar 21, 2023
Merged

[CustomOP Inplace] Add customOP inplace check #51844

merged 2 commits into from
Mar 21, 2023

Conversation

jiahy0825
Copy link
Contributor

@jiahy0825 jiahy0825 commented Mar 20, 2023 •
edited
Loading

PR types

Function optimization

PR changes

Others

Describe

Pcard-66988

[CustomOP Inplace] Add customOP inplace check

  1. Check the accuracy when users call SetInplaceMap
  2. To get inputs and outputs of OpMetaInfo, we need to use OpMetaInfoHelper in phi, so OpMetaInfoHelper has to be moved to phi.

zyfncg
zyfncg approved these changes Mar 21, 2023
View reviewed changes
paddle/phi/api/ext/op_meta_info.h

class PADDLE_API OpMetaInfoHelper;
using Tensor = paddle::Tensor;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句可以去掉了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处作为 op_meta_info.h 文件中 class OpMetaInfo 的前置声明，应该没办法去掉～

@jiahy0825 jiahy0825 merged commit d2122c6 into PaddlePaddle:develop Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyfncg zyfncg zyfncg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiahy0825 @zyfncg