[AMP OP&Test] Norm bf16 #51083
Merged
[AMP OP&Test] Norm bf16 #51083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZzSean
reviewed
Mar 2, 2023
| @@ -62,7 +62,7 @@ __global__ void Normalize(const T* x, | |||
| MT reduce_result = BlockReduce(temp_storage).Sum(sum); | |||
|
|
|||
| if (threadIdx.x == 0) { | |||
| norm = square_root(reduce_result + static_cast<MT>(eps)); | |||
ZzSean
reviewed
Mar 2, 2023
| @@ -86,7 +86,7 @@ void NormKernel(const Context& ctx, | |||
|
|
|||
| auto xdim = in_x->dims(); | |||
| if (axis < 0) axis = xdim.size() + axis; | |||
| T eps = static_cast<T>(epsilon); | |||
| float eps = epsilon; | |||
zkh2016
reviewed
Mar 6, 2023
| @@ -157,6 +159,40 @@ def init_test_case(self): | |||
| self.epsilon = 1e-8 | |||
|
|
|||
|
|
|||
| @unittest.skipIf( | |||
| not core.is_compiled_with_cuda(), | |||
| "core is not compiled with CUDA and not support the bfloat16", | |||
There was a problem hiding this comment.
"and not support the bfloat16" 这句可以去掉
Shixiaowei02
previously approved these changes
Mar 8, 2023
Vvsmile
reviewed
Mar 8, 2023
| self.check_output_with_place(core.CUDAPlace(0)) | ||
|
|
||
| def test_check_grad(self): | ||
| pass |
201716010711
dismissed stale reviews from wanghuancoder and Shixiaowei02
via
95074f7
ZzSean
reviewed
Mar 15, 2023
| @@ -119,11 +121,11 @@ def init_dtype(self): | |||
| self.dtype = "float16" | |||
|
|
|||
| def test_check_output(self): | |||
| self.check_output_with_place(fluid.core.CUDAPlace(0), atol=5e-2) | |||
|
|
||
| def test_check_grad(self): | ||
| self.check_grad_with_place( | ||
| fluid.core.CUDAPlace(0), ['X'], 'Out', max_relative_error=0.05 |
| self.python_out_sig = ["out"] | ||
|
|
||
| def test_check_output(self): | ||
| self.check_output_with_place(core.CUDAPlace(0), atol=1e-2) |
| core.CUDAPlace(0), | ||
| ['X'], | ||
| 'Out', | ||
| user_defined_grads=self.gradient, |
There was a problem hiding this comment.
self.gradient 这个参数并没有计算啊，尝试删除
| 'Out', | ||
| user_defined_grads=self.gradient, | ||
| check_eager=True, | ||
| max_relative_error=1e-2, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
add norm op test and support bf16 norm