[Extension Operants] Extension supports tensor operants #50869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
previously approved these changes
Feb 27, 2023
paddle/utils/pybind.h
Outdated
| @@ -46,6 +46,9 @@ paddle::experimental::Tensor CastPyArg2Tensor(PyObject* obj, ssize_t arg_pos); | |||
| PyObject* ToPyObject(const paddle::experimental::Tensor& value, | |||
| bool return_py_none_if_not_initialize = false); | |||
|
|
|||
| // Internal use only, switch tensor_operants_mode to phi | |||
| void SwitchTensorOperantsMode(); | |||
There was a problem hiding this comment.
这个如果是强制指定tensor_operants_mode为phi，函数名里加上PHI看上去会更直观一些
| (PyCFunction)(void (*)( | ||
| void))eager_api_init_eager_and_static_tensor_operants, | ||
| {"_init_tensor_operants", | ||
| (PyCFunction)(void (*)(void))eager_api_init_tensor_operants, |
There was a problem hiding this comment.
已和 eager 解绑
Unbind this function with eager.
YuanRisheng
reviewed
Feb 27, 2023
paddle/utils/pybind.cc
Outdated
| @@ -66,5 +69,7 @@ PyObject* ToPyObject(const paddle::experimental::Tensor& value, | |||
| return obj; | |||
| } | |||
|
|
|||
| void SwitchTensorOperantsMode() { FLAGS_tensor_operants_mode = "phi"; } | |||
There was a problem hiding this comment.
Thanks, this function can only enable phi mode. Next commit polishes the function name.
zyfncg
approved these changes
Feb 28, 2023
YuanRisheng
approved these changes
Feb 28, 2023
lanxianghit
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
After we support C++ Extension and tensor operants overloading, users can use tensor operants in Extension, this PR supports such a mechanism.
Unbind init_tensor_operants with eager, making the init process of fluid more concise.
Notice: Extension operants use
phimode, which enables C++ API without backward.Relevant PRs: