Add full_like composite rule #50794

pkuzyc · 2023-02-22T12:39:28Z

PR types

Others

PR changes

Others

Describe

Add composite rule for fill_any_like op, whose python api is paddle.full_like.

paddle-bot · 2023-02-22T12:39:36Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

CLAassistant · 2023-02-22T12:39:37Z

All committers have signed the CLA.

Charles-hit · 2023-02-22T13:17:47Z

python/paddle/fluid/tests/unittests/test_fill_any_like_op.py

@@ -29,34 +29,45 @@ def fill_any_like_wrapper(x, value):
 class TestFillAnyLikeOp(OpTest):
    def setUp(self):
        self.op_type = "fill_any_like"
-        self.python_api = fill_any_like_wrapper
+        self.prim_op_type = "comp"
+        self.enable_check_eager_comp = False


这儿不需要手动关闭，默认组合算子前向就不会测试这个，可以把self.enable_check_eager_comp = False去掉

已经删除

Charles-hit · 2023-02-22T13:18:28Z

python/paddle/fluid/tests/unittests/test_full_like_op.py

@@ -100,8 +100,11 @@ class TestFullLikeOp1(OpTest):
    # test basic
    def setUp(self):
        self.op_type = "fill_any_like"
+        self.prim_op_type = "comp"
+        self.enable_check_eager_comp = False


已经删除

Charles-hit · 2023-02-22T13:24:28Z

python/paddle/incubate/autograd/composite_rules.py

+    """op name: full_like  op type name: fill_any_like """
+    if dtype is None:
+        dtype = x.dtype
+    dtype = int_to_dtype[dtype]


去掉上面的map，这儿改成dtype = paddle.dtype(dtype)

建议改成这种用法，防止import paddle引入循环依赖
import paddle.framework.dtype as dtypes
dtype = dtypes.dtype(xxx)

修改成下面这种用法了
import paddle.framework.dtype as dtypes
dtype = dtypes.dtype(dtype)

cyber-pioneer · 2023-02-23T02:36:56Z

python/paddle/incubate/autograd/composite_rules.py

@@ -22,6 +22,8 @@

 from .primitives import *  # noqa: F403
 from .primreg import REGISTER_COMPOSITE, lookup_composite
+import pdb


cyber-pioneer · 2023-02-23T02:37:12Z

python/paddle/fluid/tests/unittests/prim/composite_ops/test_composite_full_like.py

+import paddle
+import paddle.nn.functional as F
+from paddle.fluid import core
+import pdb


把这个文件删除了

cyber-pioneer · 2023-02-23T11:49:22Z

python/paddle/incubate/autograd/composite_rules.py

+
+
+@REGISTER_COMPOSITE('fill_any_like')
+def fill_any_like(x, fill_value, dtype=None, name=None):


没有name输入，去掉；
这里输入默认值是无效的，不用设置。

已经修改，最后一个参数改成了place，默认None

cyber-pioneer · 2023-02-27T02:17:30Z

python/paddle/incubate/autograd/composite_rules.py

+    """op name: full_like  op type name: fill_any_like."""
+    """arg place is not used, add it here to keep same as python api."""
+    dtype = dtypes.dtype(dtype)
+    val = full(x.shape, fill_value, dtype, place)


full 没有place入参，去掉

Charles-hit · 2023-02-27T02:37:15Z

python/paddle/fluid/tests/unittests/CMakeLists.txt

@@ -1203,7 +1203,7 @@ if($ENV{USE_STANDALONE_EXECUTOR})
 endif()

 set(TEST_CINN_OPS test_softmax_op test_expand_v2_op test_reduce_op
-                  test_slice_op)


为什么把test_slice_op删了?

应该是误删了

cyber-pioneer · 2023-02-27T09:43:51Z

LGTM

add cinn op test to CMakeLists.txt fix code style

cyber-pioneer

LGTM

JiabinYang

LGTM

Charles-hit reviewed Feb 22, 2023

View reviewed changes

cyber-pioneer reviewed Feb 23, 2023

View reviewed changes

pkuzyc force-pushed the develop branch 3 times, most recently from 6305d1c to 4bca9e5 Compare February 23, 2023 11:21

cyber-pioneer reviewed Feb 23, 2023

View reviewed changes

pkuzyc force-pushed the develop branch 2 times, most recently from 50056f5 to 9dd6816 Compare February 24, 2023 11:44

cyber-pioneer reviewed Feb 27, 2023

View reviewed changes

pkuzyc force-pushed the develop branch from d102fb1 to 088ca0e Compare February 27, 2023 02:33

Charles-hit reviewed Feb 27, 2023

View reviewed changes

pkuzyc force-pushed the develop branch 2 times, most recently from 351fa22 to af38405 Compare February 27, 2023 05:15

pkuzyc marked this pull request as draft February 27, 2023 05:44

pkuzyc marked this pull request as ready for review February 27, 2023 05:44

pkuzyc marked this pull request as draft February 27, 2023 05:45

pkuzyc marked this pull request as ready for review February 27, 2023 05:46

pkuzyc marked this pull request as draft February 27, 2023 06:08

pkuzyc marked this pull request as ready for review February 27, 2023 06:08

pkuzyc marked this pull request as draft February 27, 2023 06:17

pkuzyc marked this pull request as ready for review February 27, 2023 06:18

cyber-pioneer previously approved these changes Feb 27, 2023

View reviewed changes

pkuzyc dismissed cyber-pioneer’s stale review via c74ecc9 February 28, 2023 02:24

pkuzyc force-pushed the develop branch 2 times, most recently from c74ecc9 to f34adc3 Compare February 28, 2023 03:34

pkuzyc added 2 commits February 28, 2023 14:52

implement composite full_like and simple unit test

91e2d10

implement op tests for composite full_like op

2c3236e

pkuzyc added 9 commits February 28, 2023 14:52

some modification as reviewers suggested

ea0cf5f

add cinn op test to CMakeLists.txt fix code style

fix code style

d7406d8

modify input args of prim fill_any_like op

6f2c7a2

resolve conflicts

c172c68

resolve conflicts

7ca4826

modify python api and unit tests as suggested

d0a42a9

resolve conflicts

d661d68

resolve conflicts

914529e

use framework.dtype to convert dtype in Op test

1b36573

pkuzyc force-pushed the develop branch from 626d754 to 1b36573 Compare February 28, 2023 06:55

cyber-pioneer approved these changes Mar 1, 2023

View reviewed changes

Charles-hit approved these changes Mar 1, 2023

View reviewed changes

JiabinYang approved these changes Mar 1, 2023

View reviewed changes

JiabinYang merged commit 7468bab into PaddlePaddle:develop Mar 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add full_like composite rule #50794

Add full_like composite rule #50794

pkuzyc commented Feb 22, 2023

paddle-bot bot commented Feb 22, 2023

CLAassistant commented Feb 22, 2023 •

edited

Loading

Charles-hit Feb 22, 2023 •

edited

Loading

pkuzyc Feb 23, 2023

Charles-hit Feb 22, 2023

pkuzyc Feb 23, 2023

Charles-hit Feb 22, 2023

cyber-pioneer Feb 23, 2023

pkuzyc Feb 23, 2023

cyber-pioneer Feb 23, 2023

pkuzyc Feb 23, 2023

cyber-pioneer Feb 23, 2023

pkuzyc Feb 23, 2023

cyber-pioneer Feb 23, 2023 •

edited

Loading

pkuzyc Feb 24, 2023

cyber-pioneer Feb 27, 2023

Charles-hit Feb 27, 2023

pkuzyc Feb 27, 2023

cyber-pioneer commented Feb 27, 2023

cyber-pioneer left a comment

JiabinYang left a comment



		@REGISTER_COMPOSITE('fill_any_like')
		def fill_any_like(x, fill_value, dtype=None, name=None):

Add full_like composite rule #50794

Add full_like composite rule #50794

Conversation

pkuzyc commented Feb 22, 2023

PR types

PR changes

Describe

paddle-bot bot commented Feb 22, 2023

CLAassistant commented Feb 22, 2023 • edited Loading

Charles-hit Feb 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyber-pioneer Feb 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyber-pioneer commented Feb 27, 2023

cyber-pioneer left a comment

Choose a reason for hiding this comment

JiabinYang left a comment

Choose a reason for hiding this comment

CLAassistant commented Feb 22, 2023 •

edited

Loading

Charles-hit Feb 22, 2023 •

edited

Loading

cyber-pioneer Feb 23, 2023 •

edited

Loading