[XPU] add fp16 support for shape and lookup_table_v2 op. #50773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houj04
changed the title
XiaociZhang
reviewed
Feb 23, 2023
|
|
||
| class XPUTestLookupTableOP(XPUOpTestWrapper): |
There was a problem hiding this comment.
好像少了几个单测？TestLookupTableWIsSelectedRows和TestEmbedOpError都没有了
There was a problem hiding this comment.
TestLookupTableWIsSelectedRows这个类的基类是unittest.TestCase，然后TestLookupTableWithTensorIdsWIsSelectedRows的基类是TestLookupTableWIsSelectedRows。这两个类，在python/paddle/fluid/tests/unittests/test_lookup_table_v2_op.py里面都有实现。
所以我特意删掉了，只按照基于XPUOpTest的方式重写了TestLookupTableOPBase以及子类。
QingshuChen
previously approved these changes
Feb 23, 2023
QingshuChen
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
shape算子添加fp16的注册。细节修改了下单测。assign算子添加double的注册。lookup_table_v2算子添加fp16的注册。重写了单测。tools/check_file_diff_approvals.sh里面针对@skip_check_grad_ci的可以执行approve操作的人的列表，但是忘记加id了。本PR补上了。