[Cpp Extension] Support optional types #50764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyfncg
reviewed
Feb 23, 2023
Comment on lines
+109
to
+127
| def _test_nullable_tensor(self): | ||
| x = custom_cpp_extension.nullable_tensor(True) | ||
| assert x is None, "Return None when input parameter return_none = True" | ||
| x = custom_cpp_extension.nullable_tensor(False).numpy() | ||
| x_np = np.ones(shape=[2, 2]) | ||
| np.testing.assert_array_equal( | ||
| x, | ||
| x_np, | ||
| err_msg='extension out: {},\n numpy out: {}'.format(x, x_np), | ||
| ) | ||
|
|
||
| def _test_optional_tensor(self): | ||
| x = custom_cpp_extension.optional_tensor(True) | ||
| assert ( | ||
| x is None | ||
| ), "Return None when input parameter return_option = True" | ||
| x = custom_cpp_extension.optional_tensor(False).numpy() | ||
| x_np = np.ones(shape=[2, 2]) | ||
| np.testing.assert_array_equal( |
There was a problem hiding this comment.
optional_tensor和nullable_tensor在功能上有什么区别吗？
There was a problem hiding this comment.
这两个分别测不同的功能，nullable_tensor 测试的是 未初始化 Tensor 返回值为 None，optional_tensor 测试的是 Extension 支持 optional 的机制
These two unit tests have different goals: nullable_tensor tests un-initialized Tensor returns None, optional_tensor tests Extension supports optional mechanism.
zyfncg
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Cpp Extension supports optional types, Extension might return
NoneorTensorwhen C++ outputsoptional<Tensor>