Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add topk prim backward #50679

Merged
merged 100 commits into from
Mar 1, 2023
Merged

Conversation

zhengqiwen1997
Copy link
Contributor

@zhengqiwen1997 zhengqiwen1997 commented Feb 20, 2023

PR types

Others

PR changes

OPs

Describe

add topk prim backward

self.python_api = paddle.topk
self.dtype = np.float64
self.dtype = np.float16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to add new test for different dtype

python/paddle/fluid/tests/unittests/test_top_k_v2_op.py Outdated Show resolved Hide resolved
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Charles-hit Charles-hit merged commit 296b3ff into PaddlePaddle:develop Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants