[phi decoupling] move platform/transform.h to phi #50498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
YuanRisheng
reviewed
Feb 15, 2023
| @@ -23,7 +23,7 @@ limitations under the License. */ | |||
| #include "thrust/device_ptr.h" | |||
|
|
|||
| namespace paddle { | |||
| namespace platform { | |||
| namespace experimental { | |||
There was a problem hiding this comment.
把命名空间直接改成phi吧，paddle::experimental是历史遗留问题，后边要废弃，另外把details目录删了吧，这个目录好像只有这一个文件，不需要给他增加目录层级
There was a problem hiding this comment.
该文件的内容已合入 transform.h
paddle/phi/common/transform.h
Outdated
| #endif | ||
|
|
||
| namespace paddle { | ||
| namespace platform { | ||
| namespace experimental { |
YuanRisheng
previously approved these changes
Feb 16, 2023
YuanRisheng
approved these changes
Feb 16, 2023
huangjiyi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
fluid/platform/tranform.handfluid/platform/details/cuda_transform_iterator_cast.htophi/common/