[pass] Upgrade Constant Folding Pass #49908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiweibo
reviewed
Jan 31, 2023
| @@ -143,6 +143,10 @@ void ConstantFoldingPass::ApplyImpl(ir::Graph *graph) const { | |||
| } | |||
| out_desc->SetShape(out_shape); | |||
| out_desc->SetPersistable(true); | |||
| auto *var_desc_out = op_node->Op()->Block()->Var(out_name); | |||
There was a problem hiding this comment.
可能是由于 Program 和 Graph 两套 IR 没法无损转换导致的问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Pass optimizations may have motifications on Graph or ProgramDesc:
TensrRT op_teller uses the information of BlockDesc inside ProgramDesc. So we should make var in OP block persistable after Constant Folding pass.
Related PR：#48763 #45494