tensor fluid code transfer part1 #41094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jeff41404
reviewed
Apr 6, 2022
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| from ..fluid.layer_helper import LayerHelper | |||
There was a problem hiding this comment.
from ..framework import LayerHelper?
jeff41404
reviewed
Apr 6, 2022
python/paddle/tensor/math.py
Outdated
| from ..fluid.layers import reduce_prod | ||
| from ..fluid.layers import elementwise_sub |
There was a problem hiding this comment.
need to decouple with reduce_prod/elementwise_sub or move them outside of fluid?
There was a problem hiding this comment.
reduce_prod已修改。
elementwise系列op与新替代API不完全兼容，应该要统一迁出，确定新路径后修改。
jzhang533
approved these changes
Apr 8, 2022
|
|
||
| out = b * \\frac{e^{a * x} - e^{-a * x}}{e^{a * x} + e^{-a * x}} | ||
|
|
||
| Parameters: |
There was a problem hiding this comment.
其他API用的是Args，这里用的是Parameters，要保持一致。
There was a problem hiding this comment.
好的，这个可能就旧代码风格，考虑这个已经approve，在另一个pr中修改。
douch
pushed a commit
to douch/Paddle
that referenced
this pull request
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
tensor fluid code transfer part1