[Phi] Move elementwise_floordiv and elementwise_pow to phi #40993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuanRisheng
previously approved these changes
Mar 28, 2022
zyfncg
reviewed
Mar 28, 2022
Comment on lines
54
to
57
| using FloorDivFunctor = phi::funcs::FloorDivideFunctor<T>; | ||
|
|
||
| template <typename T> | ||
| using InverseFloorDivFunctor = phi::funcs::InverseFloorDivideFunctor<T>; |
There was a problem hiding this comment.
FloorDivFunctor和InverseFloorDivFunctor在fluid下是否还有使用？如果没有在用的话这里可以删除
There was a problem hiding this comment.
fluid没有找到其它地方的使用，已进行删除
YuanRisheng
approved these changes
Mar 28, 2022
zyfncg
approved these changes
Mar 28, 2022
chenwhql
approved these changes
Mar 29, 2022
luotao1
pushed a commit
that referenced
this pull request
Mar 29, 2022
chenwhql
added a commit
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
Move elementwise_floordiv and elementwise_pow to phi